Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to go backwards in Malcolm install tool #487

Closed
Zokol opened this issue Jun 7, 2024 · 2 comments
Closed

No option to go backwards in Malcolm install tool #487

Zokol opened this issue Jun 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request install.py Relating to the install.py configuration script
Milestone

Comments

@Zokol
Copy link

Zokol commented Jun 7, 2024

Describe the bug
While installing Malcolm from ISO, the installation tool automatically opens.
If user select incorrect value and selects "ok", the tool does not allow reversing the selection. With multiple steps in installation process, it is likely that at some point user sets incorrect value by accident.

To Reproduce
Steps to reproduce the behavior:

  1. Start install process using Malcolm ISO
  2. Press yes on first installation step
  3. There is now no way to go back and select no for the first step without restarting the installation process

Expected behavior
Add back-button to every step to allow user to go back to previous steps

**Screenshots and/or Logs **

Malcolm Version:

  • Version [e.g. v24.05.0]

How are you running Malcolm?

@Zokol Zokol added the bug Something isn't working label Jun 7, 2024
@mmguero mmguero added this to Malcolm Jun 7, 2024
@mmguero mmguero added enhancement New feature or request install.py Relating to the install.py configuration script and removed bug Something isn't working labels Jun 10, 2024
@mmguero mmguero moved this to Triage in Malcolm Jun 10, 2024
@mmguero mmguero moved this from Triage to Todo in Malcolm Aug 26, 2024
@mmguero mmguero self-assigned this Aug 26, 2024
@mmguero mmguero added this to the v24.09.0 milestone Aug 26, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 26, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 28, 2024
@mmguero mmguero moved this from Todo to In Progress in Malcolm Aug 28, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 28, 2024
@mmguero mmguero moved this from In Progress to Testing in Malcolm Aug 28, 2024
@mmguero
Copy link
Collaborator

mmguero commented Aug 28, 2024

Image

Image

Image

Image

@mmguero
Copy link
Collaborator

mmguero commented Aug 28, 2024

the code isn't too honky to handle the back stuff:

Note that is only going to be in the "dialog" version of the script (not the plain version) and only for the -c,--configure part of the script, but I think that's the one that people care about most for this. The "install" part of the script that actually changes system files needs to go through end-to-end like before, but you do that a lot less frequently.

@mmguero mmguero moved this from Testing to Done in Malcolm Aug 28, 2024
@mmguero mmguero moved this from Done to Testing in Malcolm Aug 28, 2024
@mmguero mmguero moved this from Testing to Done in Malcolm Aug 29, 2024
@mmguero mmguero closed this as completed Aug 29, 2024
This was referenced Sep 18, 2024
@mmguero mmguero moved this from Done to Released in Malcolm Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request install.py Relating to the install.py configuration script
Projects
Status: Released
Development

No branches or pull requests

2 participants