Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only overwrite Arkime's config.ini with config.orig.ini config.ini doesn't already exist #311

Closed
mmguero opened this issue Dec 12, 2023 · 0 comments
Closed

only overwrite Arkime's config.ini with config.orig.ini config.ini doesn't already exist #311

mmguero opened this issue Dec 12, 2023 · 0 comments
Assignees
@mmguero
Labels
arkime Relating to Malcolm's use of Arkime docker Relating to docker and docker-compose as used by Malcolm enhancement New feature or request
Milestone
v23.12.1

Comments

@mmguero
Copy link
Collaborator

mmguero commented Dec 12, 2023 •
edited
Loading

There is a use case where the user might want to use their own Arkime config.ini as a bind-mount or configmap.

I'm going to change the behavior so that config.orig.ini only gets copied over on top of config.ini (and then modified with environment variables) if config.ini doesn't already exist. That way a user can, if they wish to, create their own config.ini and mount it which will be left intact.
@mmguero mmguero added docker Relating to docker and docker-compose as used by Malcolm enhancement New feature or request arkime Relating to Malcolm's use of Arkime labels Dec 12, 2023
@mmguero mmguero added this to the v23.12.1 milestone Dec 12, 2023
@mmguero mmguero self-assigned this Dec 12, 2023
@mmguero mmguero added this to Malcolm Dec 12, 2023
@mmguero mmguero moved this to Todo (design) in Malcolm Dec 12, 2023
@mmguero mmguero moved this from Todo (design) to Todo (develop) in Malcolm Dec 12, 2023
@mmguero mmguero changed the title add environment variable to indicate to not overwrite Arkime's config.ini only overwrite Arkime's config.ini with config.orig.ini config.ini doesn't already exist Dec 13, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Dec 13, 2023
@mmguero
only overwrite Arkime's config.ini with config.orig.ini config.ini do…
5d7503b 
…esn't already exist idaholab#311
@mmguero mmguero moved this from Todo (develop) to Done in Malcolm Dec 13, 2023
@mmguero mmguero closed this as completed Dec 13, 2023
This was referenced Dec 20, 2023
Merged
Merged
@mmguero mmguero moved this from Done to Released in Malcolm Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
arkime Relating to Malcolm's use of Arkime docker Relating to docker and docker-compose as used by Malcolm enhancement New feature or request
Projects
Malcolm
Status: Released
Milestone
v23.12.1
Development

No branches or pull requests
1 participant
@mmguero