Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file type validation not working for upload from (some?) windows browsers #292

Closed
mmguero opened this issue Nov 14, 2023 · 0 comments
Closed

file type validation not working for upload from (some?) windows browsers #292

mmguero opened this issue Nov 14, 2023 · 0 comments
Assignees
@mmguero
Labels
bug Something isn't working regression It worked at one point... upload Relating to PCAP and/or Zeek log ingestion
Milestone
v23.12.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Nov 14, 2023

The file type validation plugin for filepond intends to filter files that can be uploaded based on mime type. However, in Windows based browsers, this is not working with all the file types (such as pcap).

I think we could do a custom detection but I think for now we'll just remove the validation on the front-end since it's also being checked on the back-end (watch-pcap-uploads-folder.py and filebeat-watch-zeeklogs-uploads-folder.py)
@mmguero mmguero added bug Something isn't working upload Relating to PCAP and/or Zeek log ingestion regression It worked at one point... labels Nov 14, 2023
@mmguero mmguero added this to the v23.11.0 milestone Nov 14, 2023
@mmguero mmguero self-assigned this Nov 14, 2023
@mmguero mmguero added this to Malcolm Nov 14, 2023
@mmguero mmguero moved this to Testing in Malcolm Nov 14, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 14, 2023
@mmguero
fix file type validation not working for upload from (some?) windows …
684d69f 
…browsers (idaholab#292) by removig front-end validation and just relying on the backend to do it
@mmguero mmguero moved this from Testing to Done in Malcolm Nov 14, 2023
@mmguero mmguero closed this as completed Nov 14, 2023
This was referenced Dec 4, 2023
Merged
Merged
@mmguero mmguero moved this from Done to Released in Malcolm Dec 5, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jan 17, 2024
@mmguero
Merge pull request idaholab#292 from cisagov/v23.12.1_merge_cisagov
e2d4e1f 
Malcolm v23.12.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
bug Something isn't working regression It worked at one point... upload Relating to PCAP and/or Zeek log ingestion
Projects
Malcolm
Status: Released
Milestone
v23.12.0
Development

No branches or pull requests
1 participant
@mmguero