Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace master/slave with client/server when parsing modbus logs #291

Closed
mmguero opened this issue Nov 10, 2023 · 0 comments
Closed

replace master/slave with client/server when parsing modbus logs #291

mmguero opened this issue Nov 10, 2023 · 0 comments
Assignees
@mmguero
Labels
enhancement New feature or request logstash Relating to Malcolm's use of Logstash
Milestone
v23.12.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Nov 10, 2023

As per this announcement, when parsing modbus function and known_modbus device types, we'll substitute "SLAVE" with "SERVER" and "MASTER" with "CLIENT" as we massage the zeek logs.
@mmguero mmguero added enhancement New feature or request logstash Relating to Malcolm's use of Logstash labels Nov 10, 2023
@mmguero mmguero added this to the v23.11.0 milestone Nov 10, 2023
@mmguero mmguero self-assigned this Nov 10, 2023
@mmguero mmguero added this to Malcolm Nov 10, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 10, 2023
@mmguero
various updates for v23.11.0 development:
0a6565d 
* replace master/slave with client/server for modbus (idaholab#291)
* modbus updates for icsnpp-modbus (idaholab#289)
* point some Zeek plugins back upstream
* added new visualizations to modbus dashboard
@mmguero mmguero moved this to Done in Malcolm Nov 10, 2023
@mmguero mmguero closed this as completed Nov 10, 2023
This was referenced Dec 4, 2023
Merged
Merged
@mmguero mmguero moved this from Done to Released in Malcolm Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
enhancement New feature or request logstash Relating to Malcolm's use of Logstash
Projects
Malcolm
Status: Released
Milestone
v23.12.0
Development

No branches or pull requests
1 participant
@mmguero