Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prefix.description instead of VRF for identifying subnets in NetBox #280

Closed
mmguero opened this issue Oct 27, 2023 · 0 comments
Closed
Assignees
Labels
netbox Related to Malcolm's use of NetBox
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Oct 27, 2023

My original understanding of what a VRF is was incorrect, and I now think that using it as the way to tie a name to a Prefix was a mistake.

I think it would be better to use just the ipam/prefixes data model and to use description to store the name rather than do what we're currently doing.

This will inconvenience some existing users as they'll have to go fill in the prefix descriptions. Perhaps on initialization we could do that for them manually, though, if a prefix exists, its description is empty, and it has a VRF associated with it.

@mmguero mmguero added the netbox Related to Malcolm's use of NetBox label Oct 27, 2023
@mmguero mmguero added this to the v23.11.0 milestone Oct 27, 2023
@mmguero mmguero self-assigned this Oct 27, 2023
@mmguero mmguero added this to Malcolm Oct 27, 2023
@mmguero mmguero moved this to Todo (develop) in Malcolm Oct 27, 2023
@mmguero mmguero assigned mmguero and unassigned mmguero Oct 27, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Oct 31, 2023
@mmguero mmguero moved this from Todo (develop) to Testing in Malcolm Nov 9, 2023
@mmguero mmguero moved this from Testing to Done in Malcolm Nov 13, 2023
@mmguero mmguero closed this as completed Nov 13, 2023
@mmguero mmguero reopened this Nov 13, 2023
@mmguero mmguero moved this from Done to Testing in Malcolm Nov 13, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 16, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 16, 2023
…me to ipam_prefix.description (todo, need to do it in regular startup)
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 22, 2023
@mmguero mmguero moved this from Testing to Done in Malcolm Nov 27, 2023
@mmguero mmguero closed this as completed Nov 27, 2023
This was referenced Dec 4, 2023
@mmguero mmguero moved this from Done to Released in Malcolm Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netbox Related to Malcolm's use of NetBox
Projects
Status: Released
Development

No branches or pull requests

1 participant