Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modbus.log parsed incorrectly #225

Closed
mmguero opened this issue Jul 19, 2023 · 2 comments
Closed

modbus.log parsed incorrectly #225

mmguero opened this issue Jul 19, 2023 · 2 comments
Assignees
@mmguero
Labels
ics Relating to ICS (Industrial Control Systems) devices regression It worked at one point... zeek Relating to Malcolm's use of Zeek
Milestone
v23.07.1

Comments

@mmguero
Copy link
Collaborator

mmguero commented Jul 19, 2023

I need to investigate, in the Malcolm CTF there are some weird things going on with functions/exceptions being parsed from modbus.
@mmguero mmguero added ics Relating to ICS (Industrial Control Systems) devices zeek Relating to Malcolm's use of Zeek labels Jul 19, 2023
@mmguero mmguero self-assigned this Jul 19, 2023
@mmguero mmguero added this to Malcolm Jul 19, 2023
@mmguero
Copy link
Collaborator Author

mmguero commented Jul 19, 2023

Screenshot 2023-07-19 at 13-04-42 Modbus - Malcolm Dashboards

@mmguero mmguero changed the title strange modbus parsing modbus.log parsed incorrectly Jul 19, 2023
@mmguero
Copy link
Collaborator Author

mmguero commented Jul 19, 2023

We're missing some fields that were added recently:

mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jul 19, 2023
@mmguero
fix parsing of Modbus, idaholab#225
cf05d4f
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jul 19, 2023
@mmguero
for adjust modbus dashboard, idaholab#225
0b9a604 
Signed-off-by: Seth Grover <[email protected]>
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jul 20, 2023
@mmguero
for adjust modbus dashboard, idaholab#225
6548042
@mmguero mmguero added the regression It worked at one point... label Jul 20, 2023
@mmguero mmguero added this to the v23.07.1 milestone Jul 20, 2023
@mmguero mmguero moved this to In Progress in Malcolm Jul 20, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jul 20, 2023
@mmguero
better modbus action/result normalization, idaholab#225
c5c772b
@mmguero mmguero moved this from In Progress to Done in Malcolm Jul 20, 2023
@mmguero mmguero closed this as completed Jul 20, 2023
@mmguero mmguero removed the status in Malcolm Jul 20, 2023
@mmguero mmguero moved this to Done in Malcolm Jul 20, 2023
@mmguero mmguero moved this from Done to Released in Malcolm Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
ics Relating to ICS (Industrial Control Systems) devices regression It worked at one point... zeek Relating to Malcolm's use of Zeek
Projects
Malcolm
Status: Released
Milestone
v23.07.1
Development

No branches or pull requests
1 participant
@mmguero