Add validation template to HYBRID repository #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PaulTalbot-INL please have someone in the RAVEN team review. |
PaulTalbot-INL
suggested changes
Feb 15, 2022
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
klfrick2
reviewed
Feb 16, 2022
klfrick2
requested changes
Feb 16, 2022
PaulTalbot-INL
suggested changes
Mar 30, 2022
There was a problem hiding this comment.
A few cleanup things in the Python, just HYBRID-specific SQA requirements.
The paths in the ini files is a bigger issue, and I don't know how you want to pursue solving them. I will note in HERON we allowed the user to use %HERON% or something similar as a wildcard to start paths wherever HERON is installed, and navigate relative to that. Maybe this would work for this template as well?
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelCalibrationTemplate/CalibrationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/src/ModelValidationTemplate/ValidationTemplate.py
Outdated
Show resolved
Hide resolved
validationTemplate/tests/pendulumTemplateInputs/pendulum_cal.ini
Outdated
Show resolved
Hide resolved
validationTemplate/tests/pendulumTemplateInputs/pendulum_val.ini
Outdated
Show resolved
Hide resolved
validationTemplate/tests/pendulumTemplateInputs/rom_cal_pendulum.ini
Outdated
Show resolved
Hide resolved
validationTemplate/tests/pendulumTemplateInputs/rom_cal_pendulum_1var.ini
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the RAVEN validation and calibration template with HYBRID.
The folder is organized as a RAVEN plugin.