Lithium Bromide-Water Heat Pump Media and Components #14
Conversation
migration from gitlab to github. devel branch mirrored but removed history
Request to Push Devel into Master
There was a problem hiding this comment.
Submission of fewer files is needed, some of these are minor spacing changes and not direct edits. Also, files should be added individually and separately rather than as inside of existing files (see Models/NHES/Fluid/HeatExchangers/Generic_HXs/package.mo). Told Paul how to save separately and only add specific files to commits.
…ackage per Daniel's instructions. Several file names had to be changed so an upper case letter was in front. Otherwise, Dymola does not recognize it.
…o properties still return 0.0
|
The file structure was updates so packages and models are added as individual files now. I was able to remove some of the accidental (likely insignificant) changes to packages I am not involved with but not all. I know how to avoid this in future commits and pull requests. |
There was a problem hiding this comment.
We shall set up some time to help with this as much as possible.
Remove .bak-mo file extensions. These are dymola backup files and shouldn't be necessary, they're either things you deleted or temporary duplicates.
Some other files that do not appear to be from your primary work are in the commit as well.
Do not need bak-mo files.
Removing bak-mo files
Removing bak-mo files
Removing bak-mo files
Removing bak-mo files
.bak-mo
Removing bak-mo files
Models/NHES/Media/TwoPhaseMixtures/LithiumBromideWater/LiBrW_Utilities/package.mo
Outdated
Show resolved
Hide resolved
Removing bak-mo files
Removing bak-mo files
Removing bak-mo files
Removing bak-mo files
Removing bak-mo files
Removing bak-mo files
No true changes
Removing bak-mo files
Not intended change
Removing bak-mo files
Removing bak-mo files
| @@ -1,9 +0,0 @@ | |||
| within NHES.Fluid; | |||
There was a problem hiding this comment.
Can you check to make sure this should be deleted?
There was a problem hiding this comment.
It should not be deleted. I have added a heat exchanger I would like to keep and an effectiveness function for heat exchangers.
| @@ -1,5 +0,0 @@ | |||
| Examples | |||
There was a problem hiding this comment.
What's happening with this package.order file? I'm not sure why it's being deleted effectively instead of being edited or something.
| @@ -1,1229 +0,0 @@ | |||
| within NHES.Systems.BalanceOfPlant.StagebyStageTurbineSecondary; | |||
There was a problem hiding this comment.
This file shouldn't be changed. Github isn't letting me delete it.
| @@ -1,7689 +0,0 @@ | |||
| within NHES.Systems.EnergyStorage.ThermoclineHeatStorage; | |||
There was a problem hiding this comment.
This file shouldn't be changed. Github isn't letting me delete it.
| @@ -1,1391 +0,0 @@ | |||
| within NHES.Systems.BalanceOfPlant.StagebyStageTurbineSecondary; | |||
There was a problem hiding this comment.
This file shouldn't be changed. Github isn't letting me delete it.
The LiBr-H2O media package has been added. A very simple absorption cycle with the relevant components is included as well. I still plan on added chemical beds but the most recent update is giving me issues. These issues are included in the NASA_Glenn media packages, CaO and Ca(OH)2.