-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates HERON/data directory to store common HERON data. #351
Conversation
tests/integration_tests/mechanics/capacity_factors/Static.csv tests/integration_tests/mechanics/static_history/Static.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and add a lot better organization of auxiliary HERON data. As had been previously discussed, added a suggestion for updating the input specs to instruct the user about using the %HERON_DATA% environment variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file, it might be worth updating the InputData descriptions within the get_input_specs( )
methods of the ARMA(Placeholder)
and Function(Placeholder)
classes to talk about using %HERON_Data%
instead of/in addition to %HERON%
. In the modified files, these are lines 169
and 264
respectively (could not find a way to link to them directly in this comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I added descriptions of HERON_DATA to those get_input_specs.
Pull Request Description
What issue does this change request address?
Closes #352
What are the significant changes in functionality due to this change request?
Creates a %HERON_DATA% magic word used in src/Placeholders to find HERON/data
Moves shared data from inside tests to HERON/data
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.