feat(gzip): add GzipOutputStream async support #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
==========================================
+ Coverage 74.60% 74.70% +0.10%
==========================================
Files 72 72
Lines 8457 8465 +8
==========================================
+ Hits 6309 6324 +15
+ Misses 2148 2141 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piksel
force-pushed
the
feat/async-gzipos
branch
from
05557d3
to
e63c41f
Compare
piksel
force-pushed
the
feat/async-gzipos
branch
from
21c438d
to
e1511ff
Compare
For ZipStreamAsyncTest we are explicitly testing for `await using`, so it's now being marked as ignored and a dummy await is added to skip warnings For GzipAsyncTests we are testing multiple async methods, so variants are added that simply skips the `await using`/`DisposeAsync` and calls the underlying `FinishAsync`
piksel
force-pushed
the
feat/async-gzipos
branch
from
e1511ff
to
91a9b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #574 that implements
DisposeAsyncand "true" async write support toGzipOutputStream.I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.