fix(tar): permit slashed output dir #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 73.31% 73.31%
=======================================
Files 68 68
Lines 8305 8305
=======================================
Hits 6089 6089
Misses 2216 2216
Continue to review full report at Codecov.
|
piksel
force-pushed
the
fix/tararchive-slashed-outpath
branch
from
b089197
to
9c3fbfa
Compare
fixes an issue where TarArchive.ExtractContents would cause an InvalidNameException when the destination dir ended with / adds additional tests for combinations of tar file names and extraction destination paths
piksel
force-pushed
the
fix/tararchive-slashed-outpath
branch
from
9c3fbfa
to
4db5a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
TarArchive.ExtractContentswould cause anInvalidNameExceptionwhen the destination dir ended with/.Adds additional tests for combinations of tar file names and extraction destination paths.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.