Move active code from LanguageSettings to LanguageService #3302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
LanguageSettings
independent of other services injected via DISettings is the first service we need at startup, and it should not depend (even deferred) on any other service for a fast startup
There are two central changes in this PR,
LanguageSettings
andLanguageService
:Languages
toLanguageService
LanguageSettings
toLanguageService
All other changes are just side effects of the renaming/moving.