Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILSpy.ReadyToRun] Indexing the methods #1889

Closed
cshung opened this issue Jan 2, 2020 · 0 comments
Closed

[ILSpy.ReadyToRun] Indexing the methods #1889

cshung opened this issue Jan 2, 2020 · 0 comments
Labels
Help Wanted r2r
Milestone
v6.0-preview3

Comments

@cshung
Copy link
Contributor

cshung commented Jan 2, 2020

When a new method node is selected, ReadyToRunLanguage.DecompileMethod is sequentially scanning all methods just to find out matching the R2RMethod instance. This is causing a hit on switch methods. The effect is particularly pronounced in a large ready to run binary, such as System.Private.CoreLib.dll.

We maybe able to reduce the hit by indexing the R2RMethod object instances by their method tokens.
@siegfriedpammer siegfriedpammer added this to the v6.0-preview3 milestone Apr 7, 2020
siegfriedpammer added a commit that referenced this issue Apr 8, 2020
@siegfriedpammer
Fix #1889: [ILSpy.ReadyToRun] Indexing the methods
79d48a1
siegfriedpammer added a commit that referenced this issue Apr 8, 2020
@siegfriedpammer
Merge pull request #1969 from icsharpcode/fix-1889
da03896 
Fix #1889: [ILSpy.ReadyToRun] Indexing the methods
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Help Wanted r2r
Projects
None yet
Milestone
v6.0-preview3
Development

No branches or pull requests
3 participants
@siegfriedpammer @christophwille @cshung