AddParens only if it is not already a ParenthesizedExpressionSyntax #1151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
#1146
Using the test RelationalOperatorsOnNullableTypeInConditionAsync for demonstration
During the debugging session:
For vb node (with nullable variable) at the begining of ConvertBinaryExpressionAsync method :
x = y
C# code at the end of the method:
Before:
ParenthesizedExpressionSyntax ParenthesizedExpression ((((((((x))).HasValue)&&((((y))).HasValue)))&&((((((x))).Value)==((((y))).Value)))))
After:
ParenthesizedExpressionSyntax ParenthesizedExpression ((((x).HasValue)&&((y).HasValue))&&(((x).Value)==((y).Value)))
Solution
In AddParens, only add parenthesis if it is not already a ParenthesizedExpressionSyntax
This eliminate a lot of unneeded parenthesis
This is a modification to the current AddParens method. It seems to have only one definition of such method. But the
SyntaxFactory.ParenthesizedExpression
is directly call at many place in the code.