Do not use # in PR build names #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybak
added a commit
to icosa-foundation/open-blocks
that referenced
this pull request
Dec 14, 2024
See icosa-foundation/open-brush#796 [CI BUILD]
andybak
added a commit
to icosa-foundation/open-blocks
that referenced
this pull request
Dec 14, 2024
See icosa-foundation/open-brush#796 [CI BUILD]
MaoChangYuYan
pushed a commit
to MaoChangYuYan/OpenBrush_MYT
that referenced
this pull request
Dec 24, 2024
This reverts commit b9cd011.
MaoChangYuYan
pushed a commit
to MaoChangYuYan/OpenBrush_MYT
that referenced
this pull request
Dec 24, 2024
This reverts commit 865b66f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this creates a User Data folder at
file://C:\Users\foo\AppData\LocalLow\Icosa Foundation\Open Brush-(PR#1234)\which breaks GLTF loading. This PR removes the # if set, and stops trying to set it in the first place.