Initial Linux support

[technobaboo]

All basic functions of Open Brush work in Linux now, so this PR is just to add support. Some credit goes to Babouchot for their contributions (see #4)

[mikeage]

Are these tabs instead of spaces?

[mikeage]

This comment doesn't match the update; did you mean to add the Linux RuntimePlatforms to the cases?

[mikeage]

tabs again?

[technobaboo]

I fixed all of these :D

…

On Sat, Feb 6, 2021 at 9:26 PM Mike Miller ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Assets/Editor/BuildTiltBrush.cs <#32 (comment)> : > Menu.SetChecked(kMenuPlatformOsx, false); Menu.SetChecked(kMenuPlatformAndroid, false); switch (value) { case BuildTarget.StandaloneWindows64: Menu.SetChecked(kMenuPlatformWindows, true); break; + case BuildTarget.StandaloneLinux64: Are these tabs instead of spaces? ------------------------------ In Assets/Scripts/App.cs <#32 (comment)> : > @@ -1919,12 +1923,16 @@ public enum AppState { Application.OpenURL(url); } #else - // Something about the url makes OpenURL() not work on OSX, so use a workaround - if (Application.platform == RuntimePlatform.OSXEditor || - Application.platform == RuntimePlatform.OSXPlayer) { - System.Diagnostics.Process.Start(url); - } else { - Application.OpenURL(url); + // Something about the url makes OpenURL() not work on OSX or Linux, so use a workaround This comment doesn't match the update; did you mean to add the Linux RuntimePlatforms to the cases? ------------------------------ In Assets/Scripts/Sharing/DriveAccess.cs <#32 (comment)> : > @@ -99,6 +99,10 @@ private class ParentNotFound : Exception { case RuntimePlatform.OSXEditor: Debug.LogError("Host id not implemented for macOS"); return "macOS-unknown"; + case RuntimePlatform.LinuxPlayer: tabs again? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#32 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCU4EH6C25MQTU4ITGV4R3S5YB6DANCNFSM4XE7DJUQ> .

[mikeage]

Thanks. One other thing, but possibly dependent on #24 -- the target in the python script is StandaloneLinuxUniversal, not StandaloneLinux64. That'll probably need to be updated too, but maybe best to do it there (or maybe it depends on which PR gets merged first)

[mikeskydev]

I was able to build and run the output, just noting that I had to follow this guide https://github.com/ValveSoftware/SteamVR-for-Linux#runtime-requirements to be able to run it. Is it worth including a Linux section in README to highlight this? I'm not sure if it was just specific to my setup (Ubuntu 20.04 LTS). Will now test from Windows side to make sure nothing breaks.

[mikeskydev]

LGTM! No issues Windows side.

[mikeskydev]

Thanks!

[mikeage]

@technobaboo , I just wanted to let you and @Babouchot know that we now have Linux builds included as part of the automated pre-release builds!

#76

[technobaboo]

yaaaaay, so excited to get into more cool stuffs, maybe even hand tracking?

…

On Fri, Apr 2, 2021 at 9:06 AM Mike Miller ***@***.***> wrote: @technobaboo <https://github.com/technobaboo> , I just wanted to let you and @Babouchot <https://github.com/Babouchot> know that we now have Linux builds included as part of the automated pre-release builds! #76 <#76> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCU4EGEFBDAYQNXF6R6OOLTGXFPPANCNFSM4XE7DJUQ> .

[Babouchot]

@technobaboo , I just wanted to let you and @Babouchot know that we now have Linux builds included as part of the automated pre-release builds!

#76

Nice one !