Add missing parameter to on_failure block.

[jabr]

No description provided.

[iconara]

Have you had problems with that code? The parameter isn't necessary.

This does not raise any errors:

f = Future.new
f.on_failure { p :ok }
f.fail!(StandardError.new)

[jabr]

Yes, it throws "undefined local variable or method 'e'".

​The existing code passes 'e' to the fail! call in the block, but it was missing the |e| parameter for the block.

On Thu, Jun 13, 2013 at 10:15 PM, Theo Hultberg [email protected]
wrote:

Have you had problems with that code? The parameter isn't necessary.
This does not raise any errors:

f = Future.new
f.on_failure { p :ok }
f.fail!(StandardError.new)

---

Reply to this email directly or view it on GitHub:
#27 (comment)

[iconara]

Oh, right you are. I assumed I had test coverage on that so I didn't even look properly that the block used an non-existing variable/parameter. Sorry, should have looked closer.

I can fix this, but if you'd like this pull request merged I need a test that covers it.

[iconara]

I've fixed it, it's in master now. Will release a v1.0.1 soon. Thanks a lot for reporting it, and sorry for missing the real issue at first.