Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle requests multiple testcases #90

Merged
merged 8 commits into from
Sep 21, 2023
Merged

feat: handle requests multiple testcases #90

merged 8 commits into from
Sep 21, 2023

Conversation

sdpisreddevil
Copy link
Collaborator

@sdpisreddevil sdpisreddevil commented Sep 18, 2023 •
edited by AntonAndell
Loading

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@sdpisreddevil
add defaultConnection check on sendCallMessage
4ed42a4
@sdpisreddevil
add defaultConnection setter for xCall
1a494b7
@sdpisreddevil
add revert messages on require()
27e29e5
@sdpisreddevil
- add CallMessage eventLog for assertion
3f70326 
- Add Connection instances
- Add required const variables for netTo for NID and dstAccount for addr
@sdpisreddevil
add testCase for HandleResponse
7781588 
- DefaultProtocol with access
- DefaultProtocol with unauthorized access
@sdpisreddevil sdpisreddevil self-assigned this Sep 18, 2023
@sdpisreddevil sdpisreddevil changed the title feat: handle message multiple testcases feat: handle response multiple testcases Sep 18, 2023
@sdpisreddevil sdpisreddevil linked an issue Sep 18, 2023 that may be closed by this pull request
Testcase - handleRequest #39
Closed
5 tasks
@sdpisreddevil
TestCases
1d21c57 
- handleResponse with singleProtocol
- handleResponse with singleProtocol by unauthorized
@sdpisreddevil
TestCases
0901ca5 
- handleResponse with MultiProtocol
Base automatically changed from fix/add-default-connection-setter to feature/add-evm-multi-protocol-xcall September 19, 2023 05:30
AntonAndell
AntonAndell requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks okey, but they are testing handleRequests and not response.
So change naming and reference or rename correct issue

@sdpisreddevil sdpisreddevil changed the title feat: handle response multiple testcases feat: handle requests multiple testcases Sep 19, 2023
@sdpisreddevil
Copy link
Collaborator Author

Tests looks okey, but they are testing handleRequests and not response. So change naming and reference or rename correct issue

Changed to handleRequests

AntonAndell
AntonAndell approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, naming is slightly wrong but consistent with java

@AntonAndell AntonAndell merged commit 10d84e8 into feature/add-evm-multi-protocol-xcall Sep 21, 2023
3 checks passed
@AntonAndell AntonAndell deleted the feature/testcases-handleMessage-multiple branch September 21, 2023 10:52
AntonAndell added a commit that referenced this pull request Oct 23, 2023
@AntonAndell @sdpisreddevil
@gcranju @DeepakBomjan @redlarva
feat: add solidity multi protocol xCall (#86)
6779754 
* feat: setup foundry structure (#79)

* remove msg encoding in encodeCSMessageResponse

* chore: forge init

* forge install: forge-std

v1.6.1

* initial foundry setup

* forge install: openzeppelin-contracts-upgradeable

v4.9.3

* forge install: openzeppelin-contracts

v4.9.3

* add contract setup script for Callservice for Xcall

* add initial test setup for Xcall

* feat: testcase set admin (#80)

* add setAdmin testCases
- setAdmin by Owner
- setAdmin by unauthorized caller


---------

Co-authored-by: AntonAndell <[email protected]>

* feat: testcase set protocol fee (#81)

* add setProtocolFee and getProtocolFee testCases
- setProtocolFee by Owner
- setProtocolFee by added admin
- setProtocolFee by unauthrorized user

---------

Co-authored-by: AntonAndell <[email protected]>

* feat: testcase set protocol fee handler (#82)

* add setProtocolFeeHandler and getProtocolFeeHandler testCases
- setProtocolFeeHandler by Owner/Admin
- setProtocolFee by unauthrorized user

---------

Co-authored-by: AntonAndell <[email protected]>

* fix: add default connection setter (#87)

* add defaultConnection check on sendCallMessage

* add defaultConnection setter for xCall

* add revert messages on require()

* fix: rlp encode library encoding fix for protocols (#89)

* update encodeCSMessageRequest with protocol encoded code

* feat: handle requests multiple testcases (#90)

* add defaultConnection check on sendCallMessage

* add defaultConnection setter for xCall

* add revert messages on require()

* - add CallMessage eventLog for assertion
- Add Connection instances
- Add required const variables for netTo for NID and dstAccount for addr

* add testCase for HandleResponse
- DefaultProtocol with access
- DefaultProtocol with unauthorized access

* TestCases
- handleResponse with singleProtocol
- handleResponse with singleProtocol by unauthorized

* TestCases
- handleResponse with MultiProtocol

---------

Co-authored-by: AntonAndell <[email protected]>

* add successfulResponses record for responses

* update successfulResponses variable after response is success

* feat: execute call testcases (#91)

* TestCases
- executeCall using singleProtocol

* Add `CallExecuted` eventlogs for assertions

* TestCases
- executeCall using defaultProtocol

* TestCases
- executeCall using multiProtocols

* fix: clearing out unused code (#98)

* fix: clearing out unused code

* fix: clearing out contract part in library

---------

Co-authored-by: AntonAndell <[email protected]>

* docs: solidity xcall deployment (#99)

* update solidity document to deploy tthe contract as well as getting ready with forge commands

* update solidity document to deploy tthe contract as well as getting ready with forge commands

* feat: rollback testcases (#92)


* TestCases
- Rollback using singleProtocol

* TestCases
- Rollback using DefaultProtocol
- Rollback using DefaultProtocol NotAuthorized

* TestCases
- Rollback using MultiProtocol
- Rollback with SuccessMessage

* fix rollbackSuccess testcase to remove rollbackMessage eventlog

* remove rollbackMessage eventlogs from executeCall()

* feat: execute rollback testcases (#93)

* - Fix variables
- Fix Imports
- TestCases
    - ExecuteRollback using SingleProtocol
    - ExecuteRollback with DefaultProtocol
    - ExecuteRollback using MultiProtocol

* fix executeRollack testcases

* fix: testcase for send call message (#88)

* fix sendCallMessageSingleProtocol testCase

* add `CallMessgeSent` eventLog for test

* add testCase for sendMessage using multiProtocol

* add testCase for sendMessage using defaultProtocol

* Fix expectCall on sendMessage TestCases

---------

Co-authored-by: AntonAndell <[email protected]>

* fix: deployment script updated (#100)

* fix: deployment script updated

* fix: foundry.toml

* fix: nid taken from env

* update deployment script to add the setup params for xcall-multi

* update deploy script on shellScript file to deploy the contracts easily from CLI

* add .env example file to follow to deploy the xcall

---------

Co-authored-by: sdpbhandari <[email protected]>

* fix: add verify success test cases (#101)

* fix imports error after merge

* Fix verifySuccess()
Add assert on verifySuccess for rollback tests
Add assert on verifySuccess for executeRollback tests

* tests: Fix testExecuteRollbackMultiProtocol test

* feat: ci add solidity code coverages (#140)

* ci: add solidity coverage workflow

* ci: test codcov workflow

---------

Co-authored-by: Deepak Bomjan <[email protected]>

* refactor: evm folder structure

* fix: solidity xcall cod coverage

* feat: added evm multiprotocol dapp

* fix: removed unnecessary imports

* fix: remove cache file

* fix: add cache to gitignore

* fix: Add full expects of sendMessage to connections

* Ignore libraries in solidity code coverage

---------

Co-authored-by: Sudeep Bhandari <[email protected]>
Co-authored-by: gcranju <[email protected]>
Co-authored-by: Deepak Bomjan <[email protected]>
Co-authored-by: red__larva <[email protected]>
Co-authored-by: qwerty0789 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonAndell AntonAndell AntonAndell approved these changes

Assignees

@sdpisreddevil sdpisreddevil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testcase - handleRequest
2 participants
@sdpisreddevil @AntonAndell