feat: cw cluster connection #398
Conversation
sherpalden
requested review from
ibrizsabin,
nightowl121 and
AntonAndell
as code owners
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=========================================
Coverage 89.47% 89.47%
Complexity 77 77
=========================================
Files 42 42
Lines 2698 2698
Branches 37 37
=========================================
Hits 2414 2414
Misses 267 267
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. |
| let validators_set = self.get_validators(deps.storage)?; | ||
|
|
||
| if threshold as usize > validators_set.len() { | ||
| return Err(ContractError::InvalidThreshold { |
There was a problem hiding this comment.
length of validators should be greater than threshold. if threshold is greater than validator len it will never be approved.
| src_network: NetId, | ||
| conn_sn: u128, | ||
| msg: String, | ||
| ) -> Result<Response, ContractError> { |
There was a problem hiding this comment.
where are signatures here? having this method will allow relayer to bypass signature check why are we having this? I saw this in another contract as well.
| signatures, | ||
| )?; | ||
|
|
||
| if self.get_receipt(deps.as_ref().storage, src_network.clone(), conn_sn) { |
There was a problem hiding this comment.
first check receipt before validating signatures, so that we can return early.
| } | ||
| } | ||
|
|
||
| pub fn reply(&self, deps: DepsMut, _env: Env, msg: Reply) -> Result<Response, ContractError> { |
There was a problem hiding this comment.
i dont think we would need to listen to replies in connection. if it fails on xcall everything will be reverted anyway and we are not doing anything on error reply as well.
| msg: to_json_binary(&xcall_msg).unwrap(), | ||
| funds: vec![], | ||
| }); | ||
| let sub_msg: SubMsg = SubMsg::reply_always(call_message, XCALL_HANDLE_MESSAGE_REPLY_ID); |
There was a problem hiding this comment.
we can do reply never i think to make it synchronous and atomic.
| funds: vec![], | ||
| }); | ||
| let sub_msg: SubMsg = SubMsg::reply_always(call_message, XCALL_HANDLE_ERROR_REPLY_ID); | ||
| Ok(sub_msg) |
| deps.as_ref(), | ||
| threshold, | ||
| validators, | ||
| vec_msg.clone(), |
There was a problem hiding this comment.
the signed message should be srcNetwork+sn+msg not only message.
| if signers.len() >= threshold.into() { | ||
| return Ok(()); | ||
| } | ||
| break; |
There was a problem hiding this comment.
why are we doing break here ? wont it stop loop in first iteration?
| } | ||
| } | ||
|
|
||
| Ok(validators_list) |
There was a problem hiding this comment.
converting validators map to list and using that to lookup in signature verification? cant signature verification lookit up directly in the storage? if we dont want to touch storage we can return hashmap from here as well.
| pub fn ripemd160(data: &[u8]) -> Vec<u8> { | ||
| use ripemd::Digest; | ||
| ripemd::Ripemd160::digest(&data).to_vec() | ||
| } |
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: