feat: stacks #394
feat: stacks #394
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=========================================
Coverage 89.47% 89.47%
Complexity 77 77
=========================================
Files 42 42
Lines 2698 2698
Branches 37 37
=========================================
Hits 2414 2414
Misses 267 267
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. |
| ERR_NO_DEFAULT_CONNECTION) | ||
| ) | ||
|
|
||
| (define-public (send-call |
There was a problem hiding this comment.
I think message types have not been done so far right?
There was a problem hiding this comment.
it follows the same message types as contracts/javascore/xcall-lib/src/main/java/foundation/icon/xcall/CSMessage.java
There was a problem hiding this comment.
| ) | ||
| (asserts! (is-some connection-result) ERR_INVALID_NETWORK_ADDRESS) | ||
| (emit-call-message-sent-event tx-sender to next-sn) | ||
| (map-set outgoing-messages |
There was a problem hiding this comment.
Should only set if there is a rollback
| (receiver-principal (contract-of receiver)) | ||
| (from (unwrap! (as-max-len? (unwrap! (get-network-address) ERR_NOT_INITIALIZED) u128) ERR_ADDRESS_TO_PRINCIPAL_FAILED)) | ||
| (protocols (default-to (list) (get sources message))) | ||
| (rollback (unwrap! (get rollback message) ERR_NO_ROLLBACK_DATA)) |
There was a problem hiding this comment.
Isn't this set directly on send_call and thus this could be executed directly after sending no matter the result?
| (try! (contract-call? receiver handle-call-message from data protocols common)) | ||
| (emit-call-executed-event req-id CS_MESSAGE_RESULT_SUCCESS "") | ||
| (map-delete incoming-messages { req-id: req-id }) |
There was a problem hiding this comment.
Can this fail or how does this behave? This is where if there is rollback is checks if it fails and continues. If persistent it reverts the whole tx.
There was a problem hiding this comment.
if the contract call fails, it throws an error and exits the function
There was a problem hiding this comment.
But a rollback message does not fail if it fails. It then still removes the message and notifies the connection that it should respond with a failure. Seems no response has been built here
| (try! (contract-call? receiver handle-call-message from data protocols common)) | ||
| (emit-call-executed-event req-id CS_MESSAGE_RESULT_SUCCESS "") | ||
| (map-delete incoming-messages { req-id: req-id }) | ||
| (ok true) |
There was a problem hiding this comment.
Missing logic to rollback in case of failure
There was a problem hiding this comment.
what is it supposed to do if the contract call fails?
There was a problem hiding this comment.
Respond with a failure message so that it can rollback
| ((fee (unwrap! (get-fee to (> sn 0)) ERR_INVALID_FEE))) | ||
| (asserts! (>= (stx-get-balance tx-sender) fee) ERR_INVALID_FEE) | ||
| (var-set conn-sn (+ (var-get conn-sn) 1)) | ||
| (as-contract (unwrap-panic (contract-call? .xcall-proxy handle-message to msg implementation))) |
There was a problem hiding this comment.
This was added for testing?
There was a problem hiding this comment.
Ah yeah I think this was when I was initially trying to figure out how to call the proxy
Resolves #373, #374, #375, #376, #377, #378, #379