Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: icon cluster connection #386

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

bcsainju
Copy link
Collaborator

@bcsainju bcsainju commented Sep 26, 2024

Description:

Added cluster connection contract for icon chains

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@bcsainju bcsainju linked an issue Sep 26, 2024 that may be closed by this pull request
@bcsainju bcsainju changed the title Feature/icon cluster connection feat: icon cluster connection Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (4e08258) to head (d7f11de).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #386   +/-   ##
=========================================
  Coverage     89.47%   89.47%           
  Complexity       77       77           
=========================================
  Files            42       42           
  Lines          2698     2698           
  Branches         37       37           
=========================================
  Hits           2414     2414           
  Misses          267      267           
  Partials         17       17           
Flag Coverage Δ
java 85.60% <ø> (ø)
solidity 88.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bcsainju bcsainju self-assigned this Sep 26, 2024
@bcsainju bcsainju marked this pull request as ready for review October 1, 2024 11:13
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes required , else good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Cluster Connection Contract
4 participants