Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call executed event added in persistent type #358

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Sep 12, 2024

Description:

Commit Message

fix: call executed event added in persistent type

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju self-assigned this Sep 12, 2024
@gcranju gcranju added the bug Something isn't working label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (7607b6f) to head (4bbfe3e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #358   +/-   ##
=========================================
  Coverage     89.46%   89.47%           
  Complexity       77       77           
=========================================
  Files            42       42           
  Lines          2697     2698    +1     
  Branches         37       37           
=========================================
+ Hits           2413     2414    +1     
  Misses          267      267           
  Partials         17       17           
Flag Coverage Δ
solidity 88.41% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
contracts/evm/contracts/xcall/CallService.sol 97.54% <100.00%> (+0.01%) ⬆️

Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now

@gcranju gcranju merged commit 8c9fc87 into main Sep 12, 2024
14 of 17 checks passed
@gcranju gcranju deleted the fix/execute-call-persistent branch September 12, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants