Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use msgPayload hash instead of request data hash for multi protocol verification #322

Merged
merged 1 commit into from
May 27, 2024

Conversation

AntonAndell
Copy link
Collaborator

…col verification

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (1ce06ef) to head (7bc3b3f).

Current head 7bc3b3f differs from pull request most recent head 4adb8c0

Please upload reports for the commit 4adb8c0 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #322   +/-   ##
=========================================
  Coverage     89.32%   89.32%           
  Complexity       76       76           
=========================================
  Files            42       42           
  Lines          2642     2642           
  Branches         37       37           
=========================================
  Hits           2360     2360           
  Misses          265      265           
  Partials         17       17           
Flag Coverage Δ
solidity 88.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/evm/contracts/xcall/CallService.sol 97.42% <100.00%> (ø)

@gcranju gcranju added the bug Something isn't working label May 27, 2024
@gcranju gcranju changed the title fix: Use msgPayload hash instead of request data hash for multi proto… fix: Use msgPayload hash instead of request data hash for multi protocol verification May 27, 2024
@AntonAndell AntonAndell force-pushed the bugfix/evm-xcall-use-payload-hash-for-mpv branch from 7bc3b3f to 4adb8c0 Compare May 27, 2024 11:28
@gcranju gcranju merged commit 98dd4b1 into main May 27, 2024
7 checks passed
@gcranju gcranju deleted the bugfix/evm-xcall-use-payload-hash-for-mpv branch May 27, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants