Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch message type #278

Merged

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Feb 23, 2024

Description:

Reassigned message type integer value to make it backwards compatible with older message format.

Commit Message

fix: patch message type for backwards compatibility

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.22%. Comparing base (bd26104) to head (1506fe3).

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #278      +/-   ##
==================================================================================
- Coverage                                           65.08%   63.22%   -1.87%     
  Complexity                                             64       64              
==================================================================================
  Files                                                  41       42       +1     
  Lines                                                2346     2586     +240     
  Branches                                               20       20              
==================================================================================
+ Hits                                                 1527     1635     +108     
- Misses                                                809      941     +132     
  Partials                                               10       10              
Flag Coverage Δ
rust 62.02% <55.55%> (-2.48%) ⬇️
solidity 59.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/cosmwasm-vm/cw-xcall-lib/src/message/envelope.rs 15.55% <ø> (-1.12%) ⬇️
...ontracts/cosmwasm-vm/cw-xcall/src/types/request.rs 74.80% <100.00%> (-1.20%) ⬇️
...s/cosmwasm-vm/cw-xcall-lib/src/message/msg_type.rs 45.00% <33.33%> (-5.00%) ⬇️

... and 19 files with indirect coverage changes

@ibrizsabin ibrizsabin added the bug Something isn't working label Feb 23, 2024
@ibrizsabin ibrizsabin self-assigned this Feb 23, 2024
@ibrizsabin ibrizsabin marked this pull request as ready for review February 23, 2024 15:57
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrizsabin ibrizsabin merged commit 33b5427 into development/177-xcall-future-proof-messaging Feb 26, 2024
21 of 25 checks passed
@ibrizsabin ibrizsabin deleted the fix/patch-message-type branch February 26, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants