-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch message type #278
Merged
ibrizsabin
merged 8 commits into
development/177-xcall-future-proof-messaging
from
fix/patch-message-type
Feb 26, 2024
Merged
fix: patch message type #278
ibrizsabin
merged 8 commits into
development/177-xcall-future-proof-messaging
from
fix/patch-message-type
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/177-xcall-future-proof-messaging #278 +/- ##
==================================================================================
- Coverage 65.08% 63.22% -1.87%
Complexity 64 64
==================================================================================
Files 41 42 +1
Lines 2346 2586 +240
Branches 20 20
==================================================================================
+ Hits 1527 1635 +108
- Misses 809 941 +132
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ibrizsabin
requested review from
redlarva,
nightowl121 and
AntonAndell
as code owners
February 23, 2024 15:57
AntonAndell
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ibrizsabin
merged commit Feb 26, 2024
33b5427
into
development/177-xcall-future-proof-messaging
21 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reassigned message type integer value to make it backwards compatible with older message format.
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: