Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: btp2 renamed to xcall #272

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Feb 20, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju self-assigned this Feb 20, 2024
@gcranju gcranju added the enhancement New feature or request label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a7b0fe) 69.26% compared to head (b8b35ee) 69.26%.

Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                               @@
##             development/177-xcall-future-proof-messaging     #272   +/-   ##
===============================================================================
  Coverage                                           69.26%   69.26%           
  Complexity                                             64       64           
===============================================================================
  Files                                                  40       40           
  Lines                                                2203     2203           
  Branches                                               20       20           
===============================================================================
  Hits                                                 1526     1526           
  Misses                                                667      667           
  Partials                                               10       10           
Flag Coverage Δ
solidity 82.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/evm/contracts/adapters/CentralizedConnection.sol 100.00% <ø> (ø)
...tracts/evm/contracts/adapters/LayerZeroAdapter.sol 93.33% <ø> (ø)
...ntracts/evm/contracts/adapters/WormholeAdapter.sol 92.85% <ø> (ø)
...racts/evm/contracts/mocks/dapp/DAppProxySample.sol 0.00% <ø> (ø)
...ks/multi-protocol-dapp/MultiProtocolSampleDapp.sol 51.28% <ø> (ø)
contracts/evm/contracts/xcall/CallService.sol 89.52% <ø> (ø)

Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcranju gcranju merged commit c7cea6e into development/177-xcall-future-proof-messaging Feb 20, 2024
14 of 16 checks passed
@gcranju gcranju deleted the 165-remove-btp-naming-from-xcall-solidity-1 branch February 20, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants