Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readability in compare string #267

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Feb 6, 2024

Description:

Commit Message

fix: readability in compare string

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju self-assigned this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eaa0e8f) 68.85% compared to head (ff0f123) 68.88%.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #267      +/-   ##
==================================================================================
+ Coverage                                           68.85%   68.88%   +0.03%     
  Complexity                                             64       64              
==================================================================================
  Files                                                  40       40              
  Lines                                                2212     2211       -1     
  Branches                                               24       24              
==================================================================================
  Hits                                                 1523     1523              
+ Misses                                                679      678       -1     
  Partials                                               10       10              
Flag Coverage Δ
solidity 79.28% <50.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/evm/contracts/xcall/CallService.sol 83.76% <50.00%> (+0.43%) ⬆️

@gcranju gcranju added enhancement New feature or request iBriz iBriz Filter labels Feb 6, 2024
@gcranju gcranju force-pushed the 328-xcall-20-possible-performance-optimization-in-method-isreply branch from 2817ecc to ff0f123 Compare February 8, 2024 06:42
@gcranju gcranju changed the title fix: update readability in compare screen fix: readability in compare string Feb 8, 2024
@ibrizsabin ibrizsabin merged commit 785a04b into development/177-xcall-future-proof-messaging Feb 12, 2024
14 of 20 checks passed
@ibrizsabin ibrizsabin deleted the 328-xcall-20-possible-performance-optimization-in-method-isreply branch February 12, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iBriz iBriz Filter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants