Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimized in claimProtocolFee #266

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Feb 6, 2024

Description:

Commit Message

fix: optimized in claimProtocolFee

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju self-assigned this Feb 6, 2024
@gcranju gcranju added enhancement New feature or request iBriz iBriz Filter Solidity EVM chain labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eaa0e8f) 68.85% compared to head (0c37b5a) 68.83%.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #266      +/-   ##
==================================================================================
- Coverage                                           68.85%   68.83%   -0.02%     
  Complexity                                             64       64              
==================================================================================
  Files                                                  40       40              
  Lines                                                2212     2211       -1     
  Branches                                               24       24              
==================================================================================
- Hits                                                 1523     1522       -1     
  Misses                                                679      679              
  Partials                                               10       10              
Flag Coverage Δ
solidity 79.00% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/evm/contracts/xcall/CallService.sol 83.24% <100.00%> (-0.09%) ⬇️

@ibrizsabin ibrizsabin merged commit ab93b54 into development/177-xcall-future-proof-messaging Feb 12, 2024
25 of 28 checks passed
@ibrizsabin ibrizsabin deleted the 323-xcall-20-improvements-in-method-claimprotocolfee branch February 12, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iBriz iBriz Filter Solidity EVM chain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants