Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mew-message-type added in cosmwasm #246

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Jan 18, 2024

Description:

Commit Message

feat: mew-message-type added in cosmwasm

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (970b7dd) 69.65% compared to head (294e258) 67.11%.
Report is 2 commits behind head on development/177-xcall-future-proof-messaging.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #246      +/-   ##
==================================================================================
- Coverage                                           69.65%   67.11%   -2.55%     
  Complexity                                             64       64              
==================================================================================
  Files                                                  40       41       +1     
  Lines                                                2165     2405     +240     
  Branches                                               24       24              
==================================================================================
+ Hits                                                 1508     1614     +106     
- Misses                                                647      781     +134     
  Partials                                               10       10              
Flag Coverage Δ
rust 61.91% <ø> (-2.59%) ⬇️
solidity 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
But also implement response: #245 (review)

@gcranju
Copy link
Collaborator Author

gcranju commented Jan 24, 2024

Looks good. But also implement response: #245 (review)

response implementation is already there in base branch!

@AntonAndell AntonAndell merged commit 16a3a5a into development/177-xcall-future-proof-messaging Jan 24, 2024
16 of 19 checks passed
@AntonAndell AntonAndell deleted the feat/cosmwasm-dapp-new-message-type branch January 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature iBriz iBriz Filter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new message type in dapp: Rust
3 participants