Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement reply for two way messages #224

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Dec 28, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell linked an issue Jan 15, 2024 that may be closed by this pull request
@AntonAndell AntonAndell force-pushed the 189-java-implement-response-message branch from 0f9e72b to 33259ca Compare January 15, 2024 09:11
@AntonAndell AntonAndell changed the title 189 java implement response message feat: Implement reply for two way messages Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f8bff9) 69.63% compared to head (33259ca) 69.48%.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #224      +/-   ##
==================================================================================
- Coverage                                           69.63%   69.48%   -0.15%     
  Complexity                                             64       64              
==================================================================================
  Files                                                  40       40              
  Lines                                                2233     2209      -24     
  Branches                                               29       24       -5     
==================================================================================
- Hits                                                 1555     1535      -20     
+ Misses                                                665      664       -1     
+ Partials                                               13       10       -3     
Flag Coverage Δ
solidity 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...in/java/foundation/icon/xcall/CallServiceImpl.java 86.06% <ø> (+0.29%) ⬆️

@ibrizsabin ibrizsabin merged commit 76e5e28 into development/177-xcall-future-proof-messaging Jan 16, 2024
27 of 30 checks passed
@ibrizsabin ibrizsabin deleted the 189-java-implement-response-message branch January 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java: Implement Response message
2 participants