Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test #216

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Dec 20, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a9bc05a) 69.52% compared to head (452320c) 67.04%.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #216      +/-   ##
==================================================================================
- Coverage                                           69.52%   67.04%   -2.49%     
+ Complexity                                             64       62       -2     
==================================================================================
  Files                                                  40       41       +1     
  Lines                                                2169     2403     +234     
  Branches                                               24       24              
==================================================================================
+ Hits                                                 1508     1611     +103     
- Misses                                                651      781     +130     
- Partials                                               10       11       +1     
Flag Coverage Δ
rust 61.91% <0.00%> (-2.43%) ⬇️
solidity 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ontracts/cosmwasm-vm/cw-xcall-lib/src/xcall_msg.rs 0.00% <ø> (ø)
...smwasm-vm/cw-xcall-lib/src/message/call_message.rs 0.00% <0.00%> (ø)
...cw-xcall-lib/src/message/call_message_persisted.rs 0.00% <0.00%> (ø)
.../cw-xcall-lib/src/message/call_message_rollback.rs 28.57% <0.00%> (ø)
...s/cosmwasm-vm/cw-xcall-lib/src/message/envelope.rs 15.55% <0.00%> (-0.73%) ⬇️
...tracts/cosmwasm-vm/cw-xcall-lib/src/message/mod.rs 48.00% <0.00%> (-9.15%) ⬇️
contracts/cosmwasm-vm/cw-xcall/src/contract.rs 76.08% <0.00%> (+1.89%) ⬆️
...ontracts/cosmwasm-vm/cw-xcall/src/types/message.rs 41.42% <0.00%> (-1.86%) ⬇️
...ontracts/cosmwasm-vm/cw-xcall/src/types/request.rs 74.80% <0.00%> (-1.20%) ⬇️
contracts/cosmwasm-vm/cw-xcall/src/types/result.rs 49.38% <0.00%> (+2.83%) ⬆️

... and 14 files with indirect coverage changes

@github-actions github-actions bot removed the test label Dec 27, 2023
@ibrizsabin ibrizsabin marked this pull request as ready for review December 27, 2023 15:27
@github-actions github-actions bot removed the test label Dec 28, 2023
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to also add a test for the response during execution or is that to complicated?

Base automatically changed from feat/add-response-message-rust to development/177-xcall-future-proof-messaging January 16, 2024 08:27
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions github-actions bot removed the test label Jan 16, 2024
@ibrizsabin ibrizsabin merged commit 970b7dd into development/177-xcall-future-proof-messaging Jan 16, 2024
11 of 15 checks passed
@ibrizsabin ibrizsabin deleted the test/add-integration-test branch January 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants