Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add new message structure to xCall design doc #193

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Nov 10, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell linked an issue Nov 10, 2023 that may be closed by this pull request
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 10, 2023
@AntonAndell
Copy link
Collaborator Author

I am not very happy with the digram that exists and also if you guys have any feedback in making the pseudo code sections clearer that would be good.

What diagrams of xCall would you like to see @nightowl121 @sabinchitrakar @redlarva

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #193 (055416f) into main (052bb7d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #193   +/-   ##
=========================================
  Coverage     68.83%   68.83%           
  Complexity       55       55           
=========================================
  Files            32       32           
  Lines          1925     1925           
  Branches         34       34           
=========================================
  Hits           1325     1325           
  Misses          584      584           
  Partials         16       16           
Flag Coverage Δ
solidity 65.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ibrizsabin ibrizsabin changed the title docs: Add new message strucute to xCall design doc docs: Add new message structure to xCall design doc Nov 10, 2023
@ibrizsabin ibrizsabin self-requested a review November 23, 2023 04:47
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@AntonAndell AntonAndell changed the base branch from main to development/177-xcall-future-proof-messaging December 1, 2023 08:41
@AntonAndell AntonAndell merged commit 9b72397 into development/177-xcall-future-proof-messaging Dec 1, 2023
22 of 24 checks passed
@AntonAndell AntonAndell deleted the 180-design-add-new-message-structure-to-xcall-design-doc branch December 1, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: Add new message structure to xCall design doc
2 participants