feat: xcall upgradeable #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=========================================
Coverage 70.84% 70.84%
Complexity 55 55
=========================================
Files 34 34
Lines 2010 2010
Branches 34 34
=========================================
Hits 1424 1424
Misses 570 570
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I don't think this is a safe way to upgrade contracts. https://github.com/OpenZeppelin/openzeppelin-foundry-upgrades |
AntonAndell
requested changes
Nov 22, 2023
AntonAndell
reviewed
Nov 22, 2023
AntonAndell
reviewed
Nov 22, 2023
gcranju
force-pushed
the
feat/upgradeable-contracts
branch
from
fe1f653
to
053cba3
Compare
|
Looks good to me! Works as expected. Okay to merge. |
izyak
approved these changes
Dec 14, 2023
gcranju
force-pushed
the
feat/upgradeable-contracts
branch
from
053cba3
to
2f87144
Compare
gcranju
requested review from
redlarva,
ibrizsabin and
nightowl121
as code owners
AntonAndell
approved these changes
Dec 15, 2023
AntonAndell
added a commit
that referenced
this pull request
Jan 18, 2024
* feat: xcall upgradeable (#179) * feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]> * fix: network address validation fixed (#212) * fix: not authorized issue by making handleMessage public (#202) * fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]> * ci: add job to update CHANGELOG.md (#207) * fix: added rpsc in foundry.toml * fix: fix env.example * fix: new message type added in solidity * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: unnecessary event log removed * fix: sendBTPMessage renamed to sendToConnection * fix: unnecessary event log removed * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: centralized-connection test fixed * fix: proxy request structure with data hash added * fix: getFee method * fix: message encoding decoding fixed * fix: logs removed * feat: persistent messaging added in solidity * fix: foundry upgradeable version * fix: review changes on persistent messaging --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: izyak <[email protected]> Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
AntonAndell
added a commit
that referenced
this pull request
Jan 18, 2024
* feat: xcall upgradeable (#179) * feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]> * fix: network address validation fixed (#212) * fix: not authorized issue by making handleMessage public (#202) * fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]> * ci: add job to update CHANGELOG.md (#207) * fix: added rpsc in foundry.toml * fix: fix env.example * fix: new message type added in solidity * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: unnecessary event log removed * fix: sendBTPMessage renamed to sendToConnection * fix: unnecessary event log removed * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: centralized-connection test fixed * fix: proxy request structure with data hash added * fix: getFee method * fix: message encoding decoding fixed * fix: logs removed * feat: response message solidity * fix: review changes * feat: tests added * fix merge issues --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: izyak <[email protected]> Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: