Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

IS-1120: prevalidate a tx more strictly 2 #525

Merged
merged 11 commits into from
Oct 27, 2020
Merged

IS-1120: prevalidate a tx more strictly 2 #525

merged 11 commits into from
Oct 27, 2020

Conversation

endlessgate
Copy link
Contributor

@endlessgate endlessgate commented Oct 13, 2020 •
edited
Loading

Pre-validation with strict for entered transaction request

Update

  • Version check
    • Support v3 protocol only
    • Field check
  • Int-type check
    • Not allow uppercase character in hex string
    • Malformed number string: "0x03", "0x0003", "3"
  • Address-type check
    • Malformed address format: "hx1234", "0xqw1234", "cxFEAC"
    • Invalid format check
  • Required parameters check
  • Pre-validate processing in icon-service

@endlessgate
Add constant key for request parameters
399e185
@endlessgate
Pre-validate on entered request parameters
8f5cbe4 
* Malformed number string
* Not allow uppercase character
* Malformed address
* v3 protocol only
* Required fields check
@endlessgate
request parameter test for pre-validate
2fdb4f8
@endlessgate endlessgate requested a review from a team October 13, 2020 03:02
@endlessgate endlessgate self-assigned this Oct 13, 2020
@endlessgate endlessgate merged commit 749c2d2 into develop Oct 27, 2020
@endlessgate endlessgate deleted the IS-1120-prevalidate-a-tx-more-strictly-2 branch October 27, 2020 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goldworm-icon goldworm-icon goldworm-icon left review comments

Assignees

@endlessgate endlessgate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endlessgate @goldworm-icon