This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-1021: DictDB iteration causes infinite loop #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
officially we do not support iteration on DictDB so add raise Exception code references https://www.python.org/dev/peps/pep-0234/ https://docs.python.org/3/reference/datamodel.html#object.__getitem__
eunsoo-icon
suggested changes
Mar 5, 2020
tests/integrate_test/samples/sample_scores/sample_dict_db/sample_dict_db.py
Outdated
Show resolved
Hide resolved
| pass | ||
|
|
||
|
|
||
| class TestContainerDB(unittest.TestCase): |
There was a problem hiding this comment.
What is the purpose of tests? Please let me know.
There was a problem hiding this comment.
This test created a situation where iterable with getitem and it could take an infinite loop.
add comment, append detail log message
eunsoo-icon
approved these changes
Mar 5, 2020
goldworm-icon
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
officially we do not support iteration on DictDB
so add raise Exception code
references
https://www.python.org/dev/peps/pep-0234/
https://docs.python.org/3/reference/datamodel.html#object.__getitem__