This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-929: Fix a bug on PRepEngine._reset_block_validation_penalty #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goldworm-icon
commented
Dec 2, 2019
•
goldworm-icon
commented
- Change the target prep list to reset the block validation penalty from engine.preps to context.preps
- Change the condition to pick up the P-Reps to reset the block validation penalty
- Rename PRepEngine._release_block_validation_penalty() to RepEngine._reset_block_validation_penalty()
- Add a unittest to prep/test_engine.py
cow-hs
approved these changes
Dec 2, 2019
* Add a unittest to prep/test_engine.py
goldworm-icon
force-pushed
the
IS-929-bugfix-reset-block-validation-penalty
branch
from
771b711 to
5555808
Compare
goldworm-icon
deleted the
IS-929-bugfix-reset-block-validation-penalty
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.