This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-914: bugfix query_iscore #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goldworm-icon
commented
Nov 11, 2019
goldworm-icon
commented
- Invalid address of queryIScore causes RewardCalcProxy._on_send() to crash
- Add address format sanity check for queryIScore
- Catch exceptions in Server._on_send() to keep ipc sender alive
- Catch exceptions in Server._on_recv() to keep ipc receiver alive
- Add task_done() to MessageQueue
- Add an unittest for queryIScore with invalid params
added 2 commits
November 11, 2019 12:34
* Invalid address of queryIScore causes RewardCalcProxy._on_send() to crash * Add address format sanity check for queryIScore * Catch exceptions in Server._on_send() to keep ipc sender alive * Catch exceptions in Server._on_recv() to keep ipc receiver alive * Add task_done() to MessageQueue
eunsoo-icon
approved these changes
Nov 11, 2019
cow-hs
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.