Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new files for github actions testing of spack package #95

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

G-Ragghianti
Copy link
Contributor

Using this PR to test new spack package test. Don't merge yet.

@G-Ragghianti
Copy link
Contributor Author

I tested this on my fork, and it appears that the github interface requires that this spack.yml file is merged into master before we will be able to run tests manually. Therefore, I will temporarily set this to run on PRs (so that the spack tests will run in this PR), and I'll temporarily disable the other CI actions in main.yml (just for this PR) so that we don't waste resources running the automatic checks.

After we are confident that the spack test are running as desired, we should set the spack.yml to only run manually and the main.yml tests back to running automatically.

@G-Ragghianti
Copy link
Contributor Author

@mgates3 The pre-installation tests (make check) both in the cmake and spack build report skipped: requires num_devices > 0 for the gpu_amd device tests. Do you know why this would be?

@mgates3
Copy link
Collaborator

mgates3 commented Apr 29, 2024

The test_norm unit test didn't see the GPU devices due to a minor issue in the run_tests.py script, which was setting (CUDA|ROCR)_VISIBLE_DEVICES='' for test_lq. It's safe to ignore. I'll submit a work around.

@mgates3
Copy link
Collaborator

mgates3 commented May 31, 2024

The issue with test_norm skipped: requires num_devices > 0 should be now resolved by #187. See the 2 unit_test commits; sorry those are unrelated to the shared library version which was the PR's main topic, they just got rolled into it.

@G-Ragghianti
Copy link
Contributor Author

This can be merged

@mgates3 mgates3 merged commit 1bae2c8 into master Jun 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants