one approach to fix #258 and elegant #262 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just removing default handlers: remove and add Range, that, probably is less elegant way, but we can add own handler for CTRL events. More than, it fix another found ctrl+a bugs, which I saw during debug. E.g. I couldn't select with ctrl+a after typing just "@jacob ".
just removing default handlers: remove and add Range, that, probably is less elegant way, but we can add own handler for CTRL events. More than, it fix another found ctrl+a bugs, which I saw during debug. E.g. I couldn't select with ctrl+a after typing just "@jacob ".
just removing default handlers: remove and add Range, that, probably is less elegant way, but we can add own handler for CTRL events. More than, it fix another found ctrl+a bugs, which I saw during debug. E.g. I couldn't select with ctrl+a after typing just "@jacob ".
houd1ni
changed the title
|
You rock! @houd1ni . I will check it later. |
|
oh..... I forgot that the element which has |
|
Ooups, (Didn't test that issue properly -- my fail, soz) Will fix soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of absence of other bad symptoms of reselecting code, based of ranges, I prefered just removing default handlers: remove and add Range, that, probably is less elegant way, but we can add own handler for CTRL events in future. More than, it fixes another found ctrl+a bugs, which I saw during debug. E.g. I couldn't select with ctrl+a after typing just "@jacob ", which, of course, has been generated by reselecting code.
Maybe, more beautiful way is creating something like '@vars' or '@pressed_btn' objects to handle that kind of variables, but now I prefered just delete them on the fly.
Tested in Chrome, ie11, mozilla.