fix logic in transport test server #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The challenge acceptance logic was inverted since the challenge would always fail as the server and client were using different cnonce values. Make sure they are using the same cnonce, and invert the authorized check.
|
Thanks Dan, I'm a fan of your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The challenge acceptance logic was inverted since the challenge would always fail as the server and client were using different cnonce values. Make sure they are using the same cnonce, and invert the authorized check.
The validity of the change can be tested by altering the test to use the wrong password. In the original state the test incorrectly continues to pass, but the new code will now fail in that case.
Please take a look.