Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix end_of_stream detection #305

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix end_of_stream detection #305

merged 2 commits into from
Aug 11, 2023

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Aug 11, 2023

#300

peek() based detection requires extra bytes from the io.Reader. Use buffered bytes and file sizes instead.

…tes from the io.Reader. Use buffered bytes and file sizes instead.
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b77736e) 99.18% compared to head (6e740e8) 99.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          23       23           
  Lines        7258     7272   +14     
=======================================
+ Hits         7199     7213   +14     
  Misses         53       53           
  Partials        6        6           
Files Changed Coverage Δ
engine/builtin.go 99.52% <100.00%> (-0.01%) ⬇️
engine/stream.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ichiban ichiban merged commit c682cd3 into main Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant