Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine Term #249

Merged
merged 20 commits into from
Aug 28, 2022
Merged

refine Term #249

merged 20 commits into from
Aug 28, 2022

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Aug 13, 2022

#238

Refine interface Term, especially *Compound, so that we can introduce efficient representation of lists, strings, etc.

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #249 (8ba639e) into main (aa576b8) will increase coverage by 0.17%.
The diff coverage is 98.56%.

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   97.73%   97.91%   +0.17%     
==========================================
  Files          21       21              
  Lines        6767     7084     +317     
==========================================
+ Hits         6614     6936     +322     
+ Misses        122      115       -7     
- Partials       31       33       +2     
Impacted Files Coverage Δ
engine/float.go 0.00% <ø> (-93.88%) ⬇️
engine/integer.go 0.00% <ø> (-97.37%) ⬇️
engine/variable.go 86.36% <53.84%> (-13.64%) ⬇️
engine/vm.go 86.28% <90.47%> (+3.43%) ⬆️
engine/clause.go 98.63% <96.36%> (-1.37%) ⬇️
engine/env.go 98.87% <99.32%> (+0.77%) ⬆️
engine/builtin.go 97.55% <99.50%> (+0.10%) ⬆️
cmd/1pl/interpreter.go 100.00% <100.00%> (ø)
engine/atom.go 100.00% <100.00%> (ø)
engine/compound.go 100.00% <100.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ichiban ichiban marked this pull request as ready for review August 28, 2022 03:43
@ichiban ichiban merged commit e59f5c2 into main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant