Custom table elemets #141
Custom table elemets #141
Conversation
ciaranschutte
requested review from
samrichca,
justincorrigible and
joneubank
src/Table/index.tsx
Outdated
| canSort={canSort} | ||
| onClick={header.column.getToggleSortingHandler()} | ||
| > | ||
| {isCustomHeader ? ( |
There was a problem hiding this comment.
Will this ever be true? Asking b/c of return on line 160
There was a problem hiding this comment.
nice catch, looks like this will always be falsey.
There was a problem hiding this comment.
not sure I follow this thread, but we were talking about that meta property in a different PR, coincidentally.
https://github.com/icgc-argo/rdpc-ui/pull/147/files#diff-a68ddbc20eef704019906015d66875a95925225e4642a3a4b630cb9b6399c13dR740
That line there is the one that would give a truthy value to isCustomHeader here (per 133/137).
What am I missing for what you guys are agreeing on?
There was a problem hiding this comment.
aah! I see it now! yep!! copy pasta
package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "build::ts": "tsc -p ./tsconfig.json", | |||
| "build::babel": "babel ./src --extensions .tsx,.ts,.js --out-dir ./dist", | |||
| "clean": "rm -rf dist && mkdir dist", | |||
| "declarations": "ttsc --emitDeclarationOnly", | |||
| "declarations": "tsc --emitDeclarationOnly", | |||
There was a problem hiding this comment.
Do you have link/docs related to what's changing here just for my education?
There was a problem hiding this comment.
We use the TTypescript to apply absolute path handling in the "build" script, which OG TS doesn't do.
Removing this dependency would mean we cannot use absolute paths in UIKit.
ttsc is just ttypescript's tsc, which applies the patches.
There was a problem hiding this comment.
If we wanted to use an alternative approach to this, in Arranger I prepatch TS itself, rather than using TTS.
That may solve whatever issues @ciaranschutte is finding in his local env.
There was a problem hiding this comment.
I see, and from their Github, it's deprecated. Thanks!
There was a problem hiding this comment.
oh, that bit I hadn't realised. we'll have to update UIKit to account for that (different scope, unless this is a blocker here)
There was a problem hiding this comment.
putting back in ttsc for build
Description of changes
Type of Change
Checklist before requesting review: