change gql mutation uploads to use fetch #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ciaranschutte
commented
Jan 12, 2024
•
ciaranschutte
commented
- new functionality
- change gql mutation uploads to use fetch
- puts reusable stuff in places where it can be reused
ciaranschutte
requested review from
demariadaniel,
joneubank and
justincorrigible
joneubank
approved these changes
Jan 12, 2024
| const uploadFile = useMutation( | ||
| (formData) => { | ||
| const url = urlJoin(CLINICAL_API_ROOT, getProgramPath(UPLOAD_REGISTRATION, shortName)); | ||
| return uploadFileRequest(url, formData, egoJwt); |
There was a problem hiding this comment.
This function just returns the promise from the fetch to upload the form... is this awaited properly by the useMutation hook? There is also no try/catch or other error handling so I assume you tested this and the useMutation passes a failed request onto the onError function below. It is concerning that we aren't communicating any errors other than "unknown".
There was a problem hiding this comment.
the error handling is in the onError options property below.
I agree it's concerning. This is the only error case handled currently in platform-ui
There was a problem hiding this comment.
it's a different way of doing it. this is how react-query is does it. "hooks" way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.