bug/#2681-program-entity-summary-section-with-multiple-values-missing-delimiter(comma) #2745
Conversation
…t strings showing up on summary table with no space resolved
daniel-cy-lu
requested review from
ciaranschutte,
samrichca and
demariadaniel
There was a problem hiding this comment.
Why are these deleted? I've had them interfere with my local dev before, but as I remember we still want them in the repo
There was a problem hiding this comment.
Hi Dan, we are not deleting, but adding space and comma between the row that has multiple values. Right now there is no space between them. See the screenshot in this ticket: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/gh/icgc-argo/platform-ui/2681
There was a problem hiding this comment.
The code for adding commas looks fine, but the PR contains commits which delete our Husky pre-commit / pre-push files
There was a problem hiding this comment.
ohh right, I am not sure what to do with this. I was playing around because I couldn't push this ticket. let me see if I could fix it. Sorry I forgot to address this.
There was a problem hiding this comment.
@samrichca last discussed this with you, do you have any suggestions how we can get around this going forward?
There was a problem hiding this comment.
@demariadaniel I added back the husky folder and was able to git push this time. I don't the reasoning behind this though.
|
@demariadaniel Thank you Dan like always! |
daniel-cy-lu
deleted the
feat/#2681-program-entity-summary-section-with-multiple-values-missing-delimiter
branch
Issue: Program Entity table rows with multiple values are missing spaces and comma between these values. These rows are regions, countries, institutions, primarySites and cancerTypes
Solution: format the query with array.join() method. The results are values with space and commas in between.
Was able to test countries, primarySites in dev. Couldn't edit programs to test the other three rows. But since the update works on countries and primarySites, it should work for the rest as well.
Screenshot
Showing space and comma between values in primarySites and countries.
Type of Change
Checklist before requesting review