-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authorship, citation, and attribution policies #419
Conversation
👈 Launch a binder notebook on this branch for commit 31c0f41 I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 61d589f 👈 Launch a binder notebook on this branch for commit 910648b 👈 Launch a binder notebook on this branch for commit e63979c 👈 Launch a binder notebook on this branch for commit cef36c1 👈 Launch a binder notebook on this branch for commit 6198e73 👈 Launch a binder notebook on this branch for commit 976730e 👈 Launch a binder notebook on this branch for commit 4ce5f1b 👈 Launch a binder notebook on this branch for commit 0e9a768 |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## development #419 +/- ##
============================================
Coverage 59.09% 59.09%
============================================
Files 30 30
Lines 2264 2264
Branches 488 488
============================================
Hits 1338 1338
Misses 843 843
Partials 83 83 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes and I think the language used is good. I also think we could add a consideration of 'J. Scheick and icepyx developers' to the mix so Jessica's contributions can be emphasized rather than having all contributions remain anonymous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two suggestions on the CITATION.cff file, otherwise ok!
Our recent publication of all releases on Zenodo required we revisit our outdated authorship/attribution guidelines and update them to our current practices. This PR aims to update, standardize, and simplify our practices to universally recognize the "icepyx Developers" as the first author (and only author on Zenodo) of our software package.
Partially address #414.
EDIT: I would be interested in finding a way to highlight the elusively defined "significant" contributions, as well as maintainers... would be happy to add that to this PR or in a future one.