Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonParallelizable attribute to some time sensistive tests #4105

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/IceRpc.Tests/Transports/Slic/SlicIdleTimeoutTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public async Task Slic_connection_idle_after_idle_timeout()
}

[Test]
[NonParallelizable]
public async Task Slic_send_pings_are_called()
{
// Arrange
Expand Down
3 changes: 3 additions & 0 deletions tests/IceRpc.Tests/Transports/Slic/SlicTransportTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ static VersionBody DecodeVersionBody(ReadOnlySequence<byte> buffer)

/// <summary>Verifies that disabling the idle timeout doesn't abort the connection if it's idle.</summary>
[Test]
[NonParallelizable]
public async Task Connection_with_no_idle_timeout_is_not_aborted_when_idle()
{
// Arrange
Expand Down Expand Up @@ -556,6 +557,7 @@ public async Task Connection_with_no_idle_timeout_is_not_aborted_when_idle()

/// <summary>Verifies that setting the idle timeout doesn't abort the connection if it's idle.</summary>
[Test]
[NonParallelizable]
public async Task Connection_with_idle_timeout_is_not_aborted_when_idle([Values] bool serverIdleTimeout)
{
// Arrange
Expand Down Expand Up @@ -589,6 +591,7 @@ public async Task Connection_with_idle_timeout_is_not_aborted_when_idle([Values]
/// <summary>Verifies that setting the idle timeout doesn't abort the connection when there is slow write activity
/// from client to server.</summary>
[Test]
[NonParallelizable]
public async Task Connection_with_idle_timeout_and_slow_write_is_not_aborted([Values] bool serverIdleTimeout)
{
// Arrange
Expand Down