-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Configure_server_connection_listen_backlog test #4100
Conversation
Sill getting an sporadic failure when running in a loop. |
Tried with 35, but still got a failure with 47 accepted connections:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at this test, I understand that when duplexConnection.ConnectAsync() completes successfully in a client, it means:
- the server accepted the connection (via AcceptAsync on the listener), or
- the server didn't accept the connection yet but kept in the its listen backlog, and this listen backlog isn't full yet (with some wiggle room apparently)
It would be nice to explain this in the remarks of the duplex connection APIs.
Fix #4099