Upgrades to use .NET 8 RC1 #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
reviewed
Oct 10, 2023
| @@ -62,7 +62,7 @@ internal static partial class ProtocolLoggerExtensions | |||
| remoteNetworkAddress); | |||
|
|
|||
| // Multiple logging methods are using same event id. | |||
| #pragma warning disable SYSLIB1006 | |||
| #pragma warning disable SYSLIB1025 | |||
There was a problem hiding this comment.
Yes I get this new error with Visual Studio 2022 preview
There was a problem hiding this comment.
I think we should use 2 separate EventId here - for another PR!
externl
approved these changes
Oct 10, 2023
We need to use a preview version because we are depending on RC packages otherwise installing the NuGet packages will fail.
bernardnormier
approved these changes
Oct 10, 2023
| @@ -62,7 +62,7 @@ internal static partial class ProtocolLoggerExtensions | |||
| remoteNetworkAddress); | |||
|
|
|||
| // Multiple logging methods are using same event id. | |||
| #pragma warning disable SYSLIB1006 | |||
| #pragma warning disable SYSLIB1025 | |||
There was a problem hiding this comment.
I think we should use 2 separate EventId here - for another PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3678