Split test for SSL authentication with Multiplexed transports #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Oct 6, 2023
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
| var listener = provider.GetRequiredService<IListener<IMultiplexedConnection>>(); | ||
|
|
||
| // Start the TLS handshake. | ||
| var clientConnectTask = sut.Client.ConnectAsync(default); |
There was a problem hiding this comment.
Sounds like this should be simply:
await sut.Client.ConnectAsync(default);There was a problem hiding this comment.
How would this complete before we call accept?
There was a problem hiding this comment.
From the previous version of this code, I thought the connectTask succeeded.
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Quic.Tests/Transports/QuicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Tests/Transports/Slic/SlicTransportSslAuthenticationTests.cs
Show resolved
Hide resolved
tests/IceRpc.Tests/Transports/Slic/SlicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
tests/IceRpc.Tests/Transports/Slic/SlicTransportSslAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
bernardnormier
approved these changes
Oct 6, 2023
| var listener = provider.GetRequiredService<IListener<IMultiplexedConnection>>(); | ||
|
|
||
| // Start the TLS handshake. | ||
| var clientConnectTask = sut.Client.ConnectAsync(default); |
There was a problem hiding this comment.
From the previous version of this code, I thought the connectTask succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3673