Add tests for streaming messages on background (#3797)

icerpc · Nov 27, 2023 · 7260c79 · 7260c79
1 parent 3c0dd6f
commit 7260c79
Show file tree

Hide file tree

Showing 3 changed files with 424 additions and 8 deletions.
diff --git a/src/IceRpc.Protobuf/InvokerExtensions.cs b/src/IceRpc.Protobuf/InvokerExtensions.cs
@@ -162,7 +162,7 @@ public static Task<IAsyncEnumerable<TOutput>> InvokeServerStreamingAsync<TOutput
         }
 
         // ReceiveStreamingResponseAsync is responsible for disposing the request
-        return ReceiveStreamingResponseAsync(messageParser, responseTask, request, cancellationToken);
+        return ReceiveStreamingResponseAsync(messageParser, responseTask, request);
     }
 
     /// <summary>Sends a request to a service and decodes the response. This method is for Protobuf bidi-streaming
@@ -213,7 +213,7 @@ public static Task<IAsyncEnumerable<TOutput>> InvokeBidiStreamingAsync<TInput, T
         }
 
         // ReceiveStreamingResponseAsync is responsible for disposing the request
-        return ReceiveStreamingResponseAsync(messageParser, responseTask, request, cancellationToken);
+        return ReceiveStreamingResponseAsync(messageParser, responseTask, request);
     }
 
     private static async Task<TOutput> ReceiveResponseAsync<TOutput>(
@@ -251,8 +251,7 @@ private static async Task<TOutput> ReceiveResponseAsync<TOutput>(
     private static async Task<IAsyncEnumerable<TOutput>> ReceiveStreamingResponseAsync<TOutput>(
         MessageParser<TOutput> messageParser,
         Task<IncomingResponse> responseTask,
-        OutgoingRequest request,
-        CancellationToken cancellationToken) where TOutput : IMessage<TOutput>
+        OutgoingRequest request) where TOutput : IMessage<TOutput>
     {
         try
         {
@@ -264,7 +263,7 @@ private static async Task<IAsyncEnumerable<TOutput>> ReceiveStreamingResponseAsy
                 return payload.ToAsyncEnumerable(
                     messageParser,
                     protobufFeature.MaxMessageLength,
-                    cancellationToken);
+                    CancellationToken.None);
             }
             else
             {

diff --git a/tests/IceRpc.Protobuf.Tests/OperationTests.cs b/tests/IceRpc.Protobuf.Tests/OperationTests.cs
@@ -4,8 +4,6 @@
 using IceRpc.Features;
 using IceRpc.Tests.Common;
 using NUnit.Framework;
-using System.IO.Pipelines;
-using static System.Net.Mime.MediaTypeNames;
 
 namespace IceRpc.Protobuf.Tests;
 
@@ -436,7 +434,7 @@ public void Server_streaming_rpc_completes_request_and_response_payloads_upon_fa
 
         var client = new MyOperationsClient(pipeline);
 
-        // Act
+        // Act/Assert
         Assert.ThrowsAsync<DispatchException>(async () => await client.ServerStreamingOpAsync(new Empty()));
         Assert.That(() => requestPayload!.Completed, Throws.Nothing);
         Assert.That(() => responsePayload!.Completed, Throws.Nothing);